Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable whitelist of multiple operators on a single call #1491

Merged
merged 8 commits into from
Nov 26, 2024
Merged

feat: enable whitelist of multiple operators on a single call #1491

merged 8 commits into from
Nov 26, 2024

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Nov 26, 2024 •
edited
Loading

Whitelist Multiple Operators

Description

This PR adds multiple operator whitelist, changes some make target names, and internal docs about this functionality.

To Test

You can follow the new guide, verify it works.

To Deploy

in testnet: upgrade RegistryCoordinator.
in mainnet: simply deploy.

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 self-assigned this Nov 26, 2024
@uri-99 uri-99 linked an issue Nov 26, 2024 that may be closed by this pull request
feat: enable Whitelist of multiple operators on a single call #1490
Open
@uri-99 uri-99 marked this pull request as draft November 26, 2024 19:17
@uri-99 uri-99 changed the base branch from testnet to staging November 26, 2024 19:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Changes to gas cost

Generated at commit: dd4d0b01f8ea03e69aca86034b7a83aa1c15dadf, compared to commit: d57c02803650e34b3e053e136339438549e5d354

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask +262 ❌ +0.35%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 5,231,234 (0) createNewTask
receive		 56,095 (-24)
23,317 (0)		 -0.04%
0.00%		 76,060 (+262)
46,915 (+280)		 +0.35%
+0.60%		 76,247 (+96)
47,195 (0)		 +0.13%
0.00%		 77,057 (-24)
47,195 (0)		 -0.03%
0.00%		 256 (0)
256 (0)
RegistryCoordinatorHarness 5,862,162 (+125,839)

@uri-99 uri-99 mentioned this pull request Nov 26, 2024
Merged
@uri-99 uri-99 marked this pull request as ready for review November 26, 2024 20:47
MarcosNicolau
MarcosNicolau reviewed Nov 26, 2024
View reviewed changes
contracts/scripts/operator_whitelist.sh
@@ -9,8 +9,10 @@ cd "$parent_path"
cd ../

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export and source were not working for me. I had to add source scripts/.env here.

JuArce
JuArce approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve but there is missing the tutorial to whitelist operators with the multisig #1493

@JuArce JuArce added this pull request to the merge queue Nov 26, 2024
Merged via the queue into staging with commit 81b0c50 Nov 26, 2024
3 checks passed
@JuArce JuArce deleted the 1490-feat-enable-whitelist-of-multiple-operators-on-a-single-call branch November 26, 2024 23:52
PatStiles pushed a commit that referenced this pull request Nov 27, 2024
@uri-99 @PatStiles
feat: enable whitelist of multiple operators on a single call (#1491)
9d39c51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

@JuArce JuArce JuArce approved these changes

@Oppen Oppen Oppen approved these changes

Assignees

@uri-99 uri-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: enable Whitelist of multiple operators on a single call
4 participants
@uri-99 @Oppen @JuArce @MarcosNicolau